Greg KH <greg@xxxxxxxxx> writes: > On Fri, Dec 17, 2010 at 12:40:11PM -0800, Eric W. Biederman wrote: >> Greg KH <greg@xxxxxxxxx> writes: >> >> >> There are also major benefits to have the version of something that is >> >> never freed never going away, because it means you can just reference it >> >> in code. So while I would be happy to say this is special don't use a >> >> kref and roll the reference counting logic by hand, we aren't >> >> dynamically allocating init_uts_ns any time soon. >> > >> > Why have a reference count at all if it's not needed or used here? >> >> We have to reference count every other uts namespace. > > Ok, that makes sense, then also please dynamically create this one, do > not create a static kref. Nope. It's a bad idea. It messes up the kernel bootstrap if you do that, and it makes this one structure different from every other structure init_task uses. Eric _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
