Paul Menage wrote:
> On Fri, Oct 22, 2010 at 1:09 AM, Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:
>> + /*
>> + * Indicate if this subsystem can be bound/unbound to/from a cgroup
>> + * hierarchy which has child cgroups.
>> + */
>> + unsigned int can_bind:1;
>
> Maybe call this "bindable"?
>
> Basic idea looks great, it could do with a bunch more comments, and
> maybe locking rules.
>
> Is there any chance of a lock inversion between dir->i_mutex and
> cgroup_lock in hierarchy_popuiate_dir() ?
>
The lock order is:
mutex_lock(&dir->i_mutex)
mutex_lock(&cgroup_mutex)
mutex_lock(&dir->i_mutex, I_MUTEX_CHILD)
it should be safe.
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
