On Fri, Oct 22, 2010 at 01:57:55PM -0700, Matt Helsley wrote: > On Fri, Oct 22, 2010 at 04:11:41PM +0800, Li Zefan wrote: > > To make it bindable, we need to thaw all processes when unbinding > > the freezer subsystem from a cgroup hierarchy. > > > > Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx> <snip> > > Alternately you could split the bind/unbind op function pointers > and get rid of the boolean argument. Then just don't fill in the > freezer's unbind op and refuse to unbind subsystems that lack > the unbind op. That seems a bit cleaner for now at least. Or alternately to the alternate :): add a can_unbind:1 field and keep the boolean bind op argument. That might be best -- avoids an extra function pointer and still splits the bind/unbind-ability of a subsystem. Cheers, -Matt Helsley _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers