On Wed, Oct 20, 2010 at 10:23:42AM +0800, Li Zefan wrote: >Stephen Hemminger wrote: >> On Wed, 20 Oct 2010 09:43:06 +0800 >> Li Zefan <lizf@xxxxxxxxxxxxxx> wrote: >> >>> Stephen Hemminger wrote: >>>> On Tue, 19 Oct 2010 18:14:10 -0700 >>>> Paul Menage <menage@xxxxxxxxxx> wrote: >>>> >>>>> On Tue, Oct 19, 2010 at 6:12 PM, Stephen Hemminger >>>>> <shemminger@xxxxxxxxxx> wrote: >>>>>> Where is it stored in an array? >>>>>> >>>>>> ~/kernel/linux-2.6$ git grep debug_subsys >>>>>> kernel/cgroup.c: kfree(cont->subsys[debug_subsys_id]); >>>>>> kernel/cgroup.c:struct cgroup_subsys debug_subsys = { >>>>>> kernel/cgroup.c: .subsys_id = debug_subsys_id, >>>>> It's via the include of cgroup_subsys.h at the start of kernel/cgroup.c >>>>> >>>>> Paul >>>> That would work but doesn't because the following is missing >>>> in cgroup_subsys.h! >>> It's there in cgroup_subsys.h (2.6.36-rc8). What kernel are you using? >> >> Found it, thanks. Still not sure why the tools were confused. >> > >That's normal. Think about how many false positives we can get with >checkpatch.pl. > >Your tools should be static code analyzers, and the macro we use in cgroup >is too complex for them. namespace.pl is not that static. Becuase it checks the binary not the source, a little more dynamic that you think. ;) Stephen, what message did you see? _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers