Greg Thelen wrote: > Ciju Rajan K <ciju@xxxxxxxxxxxxxxxxxx> writes: > > >> Greg Thelen wrote: >> >>> Replace usage of the mem_cgroup_update_file_mapped() memcg >>> statistic update routine with two new routines: >>> * mem_cgroup_inc_page_stat() >>> * mem_cgroup_dec_page_stat() >>> >>> As before, only the file_mapped statistic is managed. However, >>> these more general interfaces allow for new statistics to be >>> more easily added. New statistics are added with memcg dirty >>> page accounting. >>> >>> >>> >>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >>> index 512cb12..f4259f4 100644 >>> --- a/mm/memcontrol.c >>> +++ b/mm/memcontrol.c >>> @@ -1592,7 +1592,9 @@ bool mem_cgroup_handle_oom(struct mem_cgroup *mem, gfp_t mask) >>> * possibility of race condition. If there is, we take a lock. >>> */ >>> >>> -static void mem_cgroup_update_file_stat(struct page *page, int idx, int >>> val) >>> >>> >> Not seeing this function in mmotm 28/09. So not able to apply this patch. >> Am I missing anything? >> > > How are you getting mmotm? > > I see the mem_cgroup_update_file_stat() routine added in mmotm > (stamp-2010-09-28-16-13) using patch file: > http://userweb.kernel.org/~akpm/mmotm/broken-out/memcg-generic-filestat-update-interface.patch > Sorry for the noise Greg. It was a mistake at my end. Corrected now. Thanks! > Author: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > Date: Tue Sep 28 21:48:19 2010 -0700 > > This patch extracts the core logic from mem_cgroup_update_file_mapped() as > mem_cgroup_update_file_stat() and adds a wrapper. > > As a planned future update, memory cgroup has to count dirty pages to > implement dirty_ratio/limit. And more, the number of dirty pages is > required to kick flusher thread to start writeback. (Now, no kick.) > > This patch is preparation for it and makes other statistics implementation > clearer. Just a clean up. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > Acked-by: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> > Reviewed-by: Greg Thelen <gthelen@xxxxxxxxxx> > Cc: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > If you are using the zen mmotm repository, > git://zen-kernel.org/kernel/mmotm.git, the commit id of > memcg-generic-filestat-update-interface.patch is > 616960dc0cb0172a5e5adc9e2b83e668e1255b50. > > >>> +void mem_cgroup_update_page_stat(struct page *page, >>> + enum mem_cgroup_write_page_stat_item idx, >>> + int val) >>> { >>> struct mem_cgroup *mem; >>> >>> >>> _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
