On Tue, 28 Sep 2010 15:50:17 +0200 Daniel Lezcano <daniel.lezcano@xxxxxxx> wrote: > On 09/27/2010 10:46 PM, Andrew Morton wrote: > > On Mon, 27 Sep 2010 15:36:58 -0500 > > "Serge E. Hallyn"<serge.hallyn@xxxxxxxxxxxxx> wrote: > > > > > >>>> This patchset removes the ns_cgroup by adding a new flag to the cgroup > >>>> and the cgroupfs mount option. It enables the copy of the parent cgroup > >>>> when a child cgroup is created. We can then safely remove the ns_cgroup as > >>>> this flag brings a compatibility. We have now to manually create and add the > >>>> task to a cgroup, which is consistent with the cgroup framework. > >>>> > >>> So this is a non-backward-compatible userspace-visible change? > >>> > >> Yes, it is. > >> > >> Patch 1 is needed to let lxc and libvirt both control containers with > >> same cgroup setup. Patch 3 however isn't *necessary* for that. Daniel, > >> what do you think about holding off on patch 3? > >> > > One way of handling this would be to merge patches 1&2 which add the > > new interface and also arrange for usage of the old interface(s) to > > emit a printk, telling people that they're using a feature which is > > scheduled for removal. > > > > Right, that makes sense. > > Do you will take the patches #1 and #2, drop the patch #3, and I send a > new patch with the printk warning ? > Or shall I resend all ? I dropped #3. Please send the printk-warning patch. I'd suggest a printk_once(), nice and verbose. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers