On 06/18, Louis Rilling wrote: > > On 17/06/10 23:20 +0200, Oleg Nesterov wrote: > > On 06/16, Louis Rilling wrote: > > > > > > Detached tasks are not seen by zap_pid_ns_processes()->sys_wait4(), so > > > that release_task()->proc_flush_task() of container init can be called > > > before it is for some detached tasks in the namespace. > > > > > > Pin proc_mnt's in copy_process(), so that proc_flush_task() becomes safe > > > whatever the ordering of tasks. > > > > I must have missed something, but can't we just move mntput() ? > > See the log of the commit introducing pid_ns_release_proc() (6f4e6433): > > Sice the namespace holds the vfsmnt, vfsmnt holds the superblock and the > superblock holds the namespace we must explicitly break this circle to destroy > all the stuff. This is done after the init of the namespace dies. I see thanks. Besides, put_pid_ns() can be called in any context... Oleg. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
