Pavel Emelyanov <xemul@xxxxxxxxxx> writes:
>> +static __inline__ void scm_destroy_cred(struct scm_cookie *scm)
>> +{
>> + put_pid(scm->pid);
>> + scm->pid = NULL;
>> +
>> + if (scm->cred)
>> + put_cred(scm->cred);
>> + scm->cred = NULL;
>> +}
>> +
>> static __inline__ void scm_destroy(struct scm_cookie *scm)
>> {
>> + scm_destroy_cred(scm);
>> if (scm && scm->fp)
>> __scm_destroy(scm);
>> }
>
> I'm a bit worried by the "if (scm" check. It makes me think scm can
> be NULL here and thus scm_destroy_cred can oops.
Interesting point. I just looked at all of the callers and scm
appears to always be valid.
Eric
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
