On Fri, 28 May 2010 15:25:08 -0700 Paul Menage <menage@xxxxxxxxxx> wrote: > On Fri, May 28, 2010 at 8:16 AM, Greg Thelen <gthelen@xxxxxxxxxx> wrote: > > > > Signed-off-by: Greg Thelen <gthelen@xxxxxxxxxx> > > Acked-by: Paul Menage <menage@xxxxxxxxxx> > > Good catch, thanks. > Nice Catch. Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> But, who breaks this ? Do we need backport this against old kernels ? 2.6.33 has this. > 3959 depth = css_depth(parent_css) + 1; > 3960 parent_id = parent_css->id; > 3961 > 3962 child_id = get_new_cssid(ss, depth); Thanks, -Kame > Paul > > > --- > > kernel/cgroup.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > > index 422cb19..3ac6f5b 100644 > > --- a/kernel/cgroup.c > > +++ b/kernel/cgroup.c > > @@ -4598,7 +4598,7 @@ static int alloc_css_id(struct cgroup_subsys *ss, struct cgroup *parent, > > parent_css = parent->subsys[subsys_id]; > > child_css = child->subsys[subsys_id]; > > parent_id = parent_css->id; > > - depth = parent_id->depth; > > + depth = parent_id->depth + 1; > > > > child_id = get_new_cssid(ss, depth); > > if (IS_ERR(child_id)) > > -- > > 1.7.0.1 > > > > > _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
