I would like to also automatically have /proc remounted, but
that would require digging deeper into lxc_clone.
Mind you perhaps having NEWPID imply NEWNS should be done there,
at src/lxc/namespace.c:lxc_clone anyway. I'm starting here...
Won't be offended if it's rejected on those grounds :)
Signed-off-by: Serge E. Hallyn <serue@xxxxxxxxxx>
---
src/lxc/lxc_unshare.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/lxc/lxc_unshare.c b/src/lxc/lxc_unshare.c
index 8db1cb7..8531b59 100644
--- a/src/lxc/lxc_unshare.c
+++ b/src/lxc/lxc_unshare.c
@@ -49,6 +49,7 @@ void usage(char *cmd)
"\t MOUNT, PID, UTSNAME, IPC, USER, NETWORK\n");
fprintf(stderr, "\t -u <id> : new id to be set if -s USER is specified\n");
fprintf(stderr, "\t if -s PID is specified, <command> is mandatory)\n");
+ fprintf(stderr, "\t If -s PID is specified, then -s MOUNT is implied\n");
_exit(1);
}
@@ -213,6 +214,9 @@ int main(int argc, char *argv[])
if (ret)
usage(argv[0]);
+ if (flags & CLONE_NEWPID)
+ flags |= CLONE_NEWNS;
+
if (!(flags & CLONE_NEWUSER) && uid != -1) {
ERROR("-u <uid> needs -s USER option");
return 1;
--
1.6.3.3
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
