Quoting Sukadev Bhattiprolu (sukadev@xxxxxxxxxxxxxxxxxx): > Serge E. Hallyn [serue@xxxxxxxxxx] wrote: > | Note that if pid > 0 you don't print out an error msg. I pushed a > | trivial patch on top of this one to do so. Pls let me know if I > | misunderstood and that wasn't right. > > Well, if the child was created (i.e pid > 0) do_child() prints a "FAIL" > message and the test exits with 1. But the message does not hurt, although Thinking in terms of future ltp integration, I'm not sure whether the child doing a TFAIL will result in parent test reporting failure on exit or not, so I prefer the parent report failure when possible. > for consistency we should mark it "FAIL" rather than "ERROR". Uh, I guess I was following you example :) I've changed both and pushed. thanks, -serge _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
