On Wed, Feb 24, 2010 at 5:28 AM, Kirill A. Shutemov <kirill@xxxxxxxxxxxxx> wrote: >> >> Using a single goto label to cleanup multi failure paths can >> get things wrong quite easily, while multi labels makes the >> code cleaner. > > I disagree. > It's easer to make mistake on changing code with multi failure > paths, if you want to move a code within function. I'm on Kirill's side here. Being able to have a single "cleanup everything" error path makes the code a lot more maintainable. It may be inappropriate for really performance-critical functions, but that's not the case here. Paul _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers