On Fri, Jan 08, 2010 at 11:33:52AM -0500, Vivek Goyal wrote: > On Fri, Jan 08, 2010 at 12:30:21AM -0500, Ben Blum wrote: > > Convert blk-cgroup to be buildable as a module > > > > From: Ben Blum <bblum@xxxxxxxxxxxxxx> > > > > This patch modifies the Block I/O cgroup subsystem to be able to be built as a > > module. As the CFQ disk scheduler optionally depends on blk-cgroup, config > > options in block/Kconfig, block/Kconfig.iosched, and block/blk-cgroup.h are > > enhanced to support the new module dependency. > > > > Signed-off-by: Ben Blum <bblum@xxxxxxxxxxxxxx> > > Two quick observations with testing. > > You need to EXPORT cgroup_path. > > Second, after loading the module, I mounted the blkio controller. But creating > a cgroup directory crashed. > > Vivek argh, good catches on both of them. didn't test with DEBUG_CFQ_IOSCHED (for cgroup_path) or with making a sub-cgroup (for the crash); shame on me. turns out it crashed because I had init_idr before init_css_set, and init_css_set sets css->id = NULL explicitly. fixed patches forthcoming. -- bblum --- block/Kconfig | 2 - block/Kconfig.iosched | 2 - block/blk-cgroup.c | 53 +++++++++++++++++++++++++++++++++++----------- block/blk-cgroup.h | 10 ++++++-- include/linux/iocontext.h | 2 - kernel/cgroup.c | 34 ++++++++++++++++++++++++----- 6 files changed, 80 insertions(+), 23 deletions(-) _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
