On Thu, 7 Jan 2010 02:48:12 -0500 Ben Blum <bblum@xxxxxxxxxxxxxx> wrote: > > 2. Making this to be reasonable value. > > #define CGROUP_SUBSYS_COUNT (BITS_PER_BYTE*sizeof(unsigned long)) > > I can't find why. > > "We limit to this many since cgroupfs_root has subsys_bits to keep track > of all of them." should it be less, perhaps? It's ok if it's clear that "this decistion is done by implementation choice, not by cgroup's nature" > the memory footprint is not > great, it is true, but implementing dynamically sized subsystem tracking > data structures requires much cleverer code in many places. > yes. I don't request that. > > 3. show whehter a subsys is a loadable module or not via /proc/cgroups > > with just "y" or "n"? possible, and probably easy. do note that since > they are sorted by subsys_id, all the ones above a certain line will be > "n" and all below will be "y". > yes. #subsys_name hierarchy num_cgroups enabled module cpuset 0 1 1 0 and 0/1 to show y/n ? (but this cause interface incompatibility...) Thanks, -Kame _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
