On Tue, 15 Dec 2009 17:03:37 +0200
"Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx> wrote:
> >> > + /*
> >> > + * Unregister events and notify userspace.
> >> > + * FIXME: How to avoid race with cgroup_event_remove_work()
> >> > + * which runs from workqueue?
> >> > + */
> >> > + mutex_lock(&cgrp->event_list_mutex);
> >> > + list_for_each_entry_safe(event, tmp, &cgrp->event_list, list) {
> >> > + cgroup_event_remove(event);
> >> > + eventfd_signal(event->eventfd, 1);
> >> > + }
> >> > + mutex_unlock(&cgrp->event_list_mutex);
> >> > +
> >> > +out:
> >> > return ret;
> >> > }
> >
> > How ciritical is this FIXME ?
> > But Hmm..can't we use RCU ?
>
> It's not reasonable to have RCU here, since event_list isn't mostly-read.
>
ok.
Thanks,
-Kame
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
