Re: [PATCH 1/1] implement s390 clone_with_pids syscall

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +	parent_tid_ptr = (int *)kca.parent_tid_ptr;
> +	child_tid_ptr =  (int *)kca.child_tid_ptr;
> +
> +	stack_size = (unsigned long)kca.child_stack_size;
> +	child_stack = (unsigned long)kca.child_stack_base;
> +	if (child_stack)
> +		child_stack += stack_size;

Should this calculation not be of the form:
child_stack = arch_dependent_alignment(child_stack + stack_size - 1)
?

Is overflow a concern?

Same questions apply to the x86 version.


_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers

[Index of Archives]     [Cgroups]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux