On Mon, Nov 02, 2009 at 08:39:59PM -0600, Serge E. Hallyn wrote:
> Quoting Matt Helsley (matthltc@xxxxxxxxxx):
> > On Mon, Nov 02, 2009 at 04:23:29PM -0600, serue@xxxxxxxxxx wrote:
> > > From: Serge E. Hallyn <serue@xxxxxxxxxx>
> ...
<snip>
> > > +#define _ckpt_err(ctx, fmt, args...) do { \
> > > + _do_ckpt_msg(ctx, "[ error %s:%d]" fmt, __func__, __LINE__, ##args); \
> > > +} while (0)
> > > +
> > > +/* ckpt_logmsg() or ckpt_msg() will do do_ckpt_msg with an added
> > > + * prefix */
> >
> > nit: This comment is about future code. It should perhaps be part of
> > the patch description rather than in the code as comment.
>
> Sure - and if there are no basic objectiosn then apart from addressing
> these I'll also aim to put some meaningful ckpt_errs() on restart failure
> paths tomorrow.
No objections from me.
Acked-by: Matt Helsley <matthltc@xxxxxxxxxx>
Cheers,
-Matt Helsley
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
