Serge E. Hallyn wrote: > Quoting Oren Laadan (orenl@xxxxxxxxxxx): >> >> Matt Helsley wrote: >>> Unlike the length passed into ckpt_write_obj_type, the maximum length passed >>> to ckpt_read_buf_type must include the length of the struct ckpt_hdr. >> IMHO, the right way to fix this is to change ckpt_read_obj_type(). >> >> This will preserve symmetry between checkpoint and restart, and also >> fix a similar problem in kernel/groups.c (MAX_GROUPINFO_SIZE). >> >> No need to resend - I'll fix already. > > Oren: note with your version of the patch, restore_open_fname() > does 'return len' giving me > > checkpoint/files.c: In function 'restore_open_fname': > checkpoint/files.c:457: warning: return makes pointer from integer without a cast Oops ... that's silly. Fix queued. Thanks, Oren. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
