OL> IIRC, the TCP stack takes the timestamp for each packet directly OL> from jiffies. So you need to teach TCP to add a per-container (or OL> you can make it per-socket) delta to that timestamp. After wondering what the heck you were talking about, I realized I assumed you were talking about TCP timeouts and not timestamps :) I assume you mean the following: 1. Put a absolute time stamp in the checkpoint stream 2. Calculate the delta between that and the current time on the restoring host 3. Use that value to offset timestamps from that point on. Correct? Since I brought it up, do you agree that the retransmit timers should be canonicalized to time-after checkpoint values? It occurs to me that right now I restore a jiffies value on the receiving host which is guaranteed to be incorrect :) OL> So I'm thinking, for both, do (1) put a big fat comment in the OL> code saying that sanity-tests are needed, and what for, and (2) OL> send a separate mail to the networking people with these two OL> scenarios and request comments ? Yeah, although I would hope that they're seeing this conversation and would chime in (hence the cc:netdev). Hopefully I don't have to disguise a separate email as non-C/R related to get past their filters! :) OL> For example, now, if a user wants to send a TCP packet with OL> arbitrary protocol parameters, he needs to use raw IP sockets, OL> which require privilege. Would restarting a connection with the OL> desired parameters become a way to bypass that restriction ? OL> (e.g. assume the user restarts while using the host's network OL> namespace). Um, yeah? I don't see much way around that if we're going to trust any of what is in the checkpoint stream. Perhaps we say CAP_NET_ADMIN is required to restart a live TCP connection? -- Dan Smith IBM Linux Technology Center email: danms@xxxxxxxxxx _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers