Sukadev Bhattiprolu wrote:
>
> Would it be easier/cleaner if we initialized the restart ctx soon after
> allocating it ? Looks like we already have the information we need at that
> point.
>
> That way, do_restart() won't need the 'pid' parameter and we anyway use
> the 'if(ctx)' check to test for the coordinator.
I put the {checkpoint,restart}-related work in {checkpoint,restart}.c,
and leave sys.c "neutral".
I also like the symmetry between do_checkpoint() and do_restart() :p
> BTW, can we move the '->active_pid = -1' in init_restart_ctx() to
> ckpt_ctx_alloc() itself ?
@active_pid is specific to restart, that's why I initialize it there.
Oren.
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
