On Thu, Aug 20, 2009 at 02:13:56PM -0700, Andrew Morton wrote:
> On Wed, 19 Aug 2009 19:45:11 -0700
> Paul Menage <menage@xxxxxxxxxx> wrote:
>
> > On Wed, Aug 19, 2009 at 7:39 PM, Li Zefan<lizf@xxxxxxxxxxxxxx> wrote:
> > >
> > >> + __ __ __ __ __ __ list_for_each_entry_rcu(p, &tsk->thread_group, thread_group) {
> > >> + __ __ __ __ __ __ __ __ __ __ if (p->sighand) {
> > >> + __ __ __ __ __ __ __ __ __ __ __ __ __ __ sighand = tsk->sighand;
>
> (^^ who did that?)
>
The tsk->sighand? Likely me. I'm surprised it took that many pairs of eyes
to catch it.
> > >
> > > s/tsk->sighand/p->sighand
> >
> > Good catch, thanks. Fixed.
> >
>
> I see no fix anywhere so I did this:
>
> --- a/kernel/cgroup.c~cgroups-add-functionality-to-read-write-lock-clone_thread-forking-per-threadgroup-fix
> +++ a/kernel/cgroup.c
> @@ -1557,7 +1557,7 @@ struct sighand_struct *threadgroup_fork_
> rcu_read_lock();
> list_for_each_entry_rcu(p, &tsk->thread_group, thread_group) {
> if (p->sighand) {
> - sighand = tsk->sighand;
> + sighand = p->sighand;
> break;
> }
> }
>
>
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
