Grzegorz Nosek [root@xxxxxxxxxxxxxx] wrote:| On śro, lip 22, 2009 at 06:48:55 -0700, H. Peter Anvin wrote:| > > | Bisecting...| | OK, the first bad commit is:| commit 4a2b5fddd53b80efcb3266ee36e23b8de28e761a| Author: Sukadev Bhattiprolu <sukadev@xxxxxxxxxx>| Date: Mon Oct 13 10:42:49 2008 +0100| | Move tty lookup/reopen to caller| | Move tty_driver_lookup_tty() and tty_reopen() from tty_init_dev()| into tty_open() (one of the two callers of tty_init_dev()). These| calls are not really required in ptmx_open(), the other caller,| since ptmx_open() would be setting up a new tty.| | Changelog[v2]:| - remove the lookup and reopen calls from ptmx_open| - merge with recent changes to ttydev tree| | Signed-off-by: Sukadev Bhattiprolu <sukadev@xxxxxxxxxx>| Signed-off-by: Alan Cox <alan@xxxxxxxxxx>| Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>| | However, with HEAD there the behaviour is slightly different as the| kernel does not crash (loudly) and the open succeeds but silently| leaves the tty layer locked, so it's just as bad.| Yes, I think this was fixed by 808ffa3d302257b9dc37b1412c1fcdf976fcddac | The oops itself is introduced by:| commit 527b3e4773628b30d03323a2cb5fb0d84441990f| Author: Sukadev Bhattiprolu <sukadev@xxxxxxxxxx>| Date: Mon Oct 13 10:43:08 2008 +0100| | Simplify devpts_get_tty()| | As pointed out by H. Peter Anvin, since the inode for the pty is known,| we don't need to look it up.| | Signed-off-by: Sukadev Bhattiprolu <sukadev@xxxxxxxxxx>| Signed-off-by: Alan Cox <alan@xxxxxxxxxx>| Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> Maybe before returning the tty, we need to take an extra reference onthe dentry. Sukadev _______________________________________________Containers mailing listContainers@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx://lists.linux-foundation.org/mailman/listinfo/containers
