[Oren Laadan - Wed, Jul 22, 2009 at 06:00:14AM -0400] ... | +static struct sem *restore_sem_array(struct ckpt_ctx *ctx, int nsems) | +{ | + struct sem *sma; | + int i, ret; | + | + sma = kmalloc(nsems * sizeof(*sma), GFP_KERNEL); Forgot to if (!sma) return -ENOMEM; right? | + ret = _ckpt_read_buffer(ctx, sma, nsems * sizeof(*sma)); | + if (ret < 0) | + goto out; | + | + /* validate sem array contents */ | + for (i = 0; i < nsems; i++) { | + if (sma[i].semval < 0 || sma[i].sempid < 0) { | + ret = -EINVAL; | + break; | + } | + } | + out: | + if (ret < 0) { | + kfree(sma); | + sma = ERR_PTR(ret); | + } | + return sma; | +} ... -- Cyrill _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers