On 06/18, Oleg Nesterov wrote: > > On 06/17, Sukadev Bhattiprolu wrote: > > > > @@ -974,6 +974,14 @@ static struct task_struct *copy_process( > > if ((clone_flags & CLONE_SIGHAND) && !(clone_flags & CLONE_VM)) > > return ERR_PTR(-EINVAL); > > > > + /* > > + * To keep pid namespace semantics simple, prevent container-inits > > + * from creating siblings. > > + */ > > + if ((clone_flags & CLONE_PARENT) && > > + is_container_init(current) && !is_global_init(current)) > > Both is_ checks are not right afaics. There are per-thread. This means > that container-init can do clone(CLONE_THREAD), and then this thread > does CLONE_PARENT and fools copy_process(). > > As for !is_global_init(). I never understood what should we do if the > global init does CLONE_PARENT, this attaches another process to swapper, > not good. Hmm. And idle threads run with ->action[SIGHLD] == SIG_DFL, so this is really wrong. Fortunately, we can trust the global init. Oleg. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
