Re: [PATCH 1/1] cls_cgroup: Fix oops when user send improperly 'tc filter add' request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Minoru Usui <usui@xxxxxxxxxxxxxxxxx>
Date: Tue, 9 Jun 2009 08:54:08 +0900

> cls_cgroup: Fix oops when user send improperly 'tc filter add' request
> 
> I found a bug in cls_cgroup_change() in cls_cgroup.c.
> cls_cgroup_change() expected tca[TCA_OPTIONS] was set from user space properly,
> but tc in iproute2-2.6.29-1 (which I used) didn't set it.
> 
> In the current source code of tc in git, it set tca[TCA_OPTIONS].
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git
> 
> If we always use a newest iproute2 in git when we use cls_cgroup, 
> we don't face this oops probably.
> But I think, kernel shouldn't panic regardless of use program's behaviour. 
> 
> Signed-off-by: Minoru Usui <usui@xxxxxxxxxxxxxxxxx>

Patch applied, thank you.
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers

[Index of Archives]     [Cgroups]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux