On Fri, Mar 27, 2009 at 10:56:51AM -0400, Oren Laadan wrote: > > > Matt Helsley wrote: > > In case anyone's curious here is my list of filesystems which I think should > > have generic_file_checkpoint fops (31): > > Thanks, Matt. You're welcome! <snip> > > ramfs > > I'd think that in the case of ramfs we always need to dump the contents of the > file, or the entire file system, with the checkpoint image. I anticipated Dave's answer when I lumped ramfs with "regular" filesystems. To the best of my knowledge it doesn't matter what kind of "block" device backs these files. Only that the file contents can be migrated somehow and that they support the seek operation. Note that procfs is difficult for checkpoint/restart because the contents often can't be migrated using rsync. Each non-process /proc file probably will need its own checkpoint operation. I suspect this would frequently need to be passed through an extended seq_file API much like the checkpoint op extends the VFS file_operations. > > reiserfs > > romfs > > squashfs > > sysv > > ubifs > > udf > > ufs > > xfs > > > > I also added the checkpoint operation to generic_ro_fops since it's used > > only in the set of filesystems listed above. For the curious: > > befs > > cramfs > > efs > > freevxfs > > isofs > > romfs > > squashfs The patch modifying generic_ro_fops doesn't quite match the pattern established when patching the other filesystems so I thought it deserved special mention. The other filesystems all define their own file_operation structs but these share one. Amongst other things these filesystems do not allow modifications to their file contents. Consequently they share generic_ro_fops rather than define their own file operations. cramfs, isofs, romfs, and squashfs are designed to be static, offline-generated filesystems so generic_ro_fops makes sense here. I guess befs, freevxfs, and efs are legacy filesystems and there is little reason to implement write operations for them. Cheers, -Matt _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
