Re: C/R review

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2009-03-18 at 00:01 +0300, Alexey Dobriyan wrote:
> > +static inline loff_t file_pos_read(struct file *file)
> > +{
> > +     return file->f_pos;
> > +}
> > +
> > +static inline void file_pos_write(struct file *file, loff_t pos)
> > +{
> > +     file->f_pos = pos;
> > +}
> 
> I failed myself to understand need for this wrappers at all.
> 
> If dump is single-threaded, who is going to change f_pos under you?
> 
> I'm passing &file->f_pos to vfs_write().

/me git-blames...

They're already in the kernel and they've been there since the beginning
of git as far as I can see.  I think Oren was just trying to use what is
there already, so he moved them to a header.

-- Dave

_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers

[Index of Archives]     [Cgroups]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux