On Mon, 2 Mar 2009 10:19:15 -0800 Paul Menage <menage@xxxxxxxxxx> wrote: > On Sun, Mar 1, 2009 at 6:13 PM, Li Zefan <lizf@xxxxxxxxxxxxxx> wrote: > > Now a cgroup subsystem can set default file mode of its control files, > > so here is a patchset to correct file mode of each subsystem's files. > > I really think that we should be defaulting this based on whether the > control file has read or write handlers. > > Sure, there are special cases like "tasks" that we'd need to set a > manual value for, but most of these patches would be unnecessary. > like this ? int mode; if (cft->mode) mode = cft->mode; else if (cft->write_xxx || .....) mode = 0644; else mode = 0444; Thanks, -Kame _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
