2009/2/27 Dave Hansen <dave@xxxxxxxxxxxxxxxxxx>:>> I'll be adding to this in a moment and it is in a bad place> to do that cleanly now.>> Also, increase the buffer size. Most /proc files can> output up to a page, so use the same here.>> Signed-off-by: Dave Hansen <dave@xxxxxxxxxxxxxxxxxx>> --->> linux-2.6.git-dave/fs/proc/base.c | 23 +++++++++++++++--------> 1 file changed, 15 insertions(+), 8 deletions(-)>> diff -puN fs/proc/base.c~breakout-fdinfo fs/proc/base.c> --- linux-2.6.git/fs/proc/base.c~breakout-fdinfo 2009-02-27 12:07:37.000000000 -0800> +++ linux-2.6.git-dave/fs/proc/base.c 2009-02-27 12:07:37.000000000 -0800> @@ -1632,7 +1632,18 @@ out:> return ~0U;> }>> -#define PROC_FDINFO_MAX 64> +#define PROC_FDINFO_MAX PAGE_SIZE> +> +static void proc_fd_write_info(struct file *file, char *info)> +{> + int max = PROC_FDINFO_MAX;> + int p = 0;> + if (!info)> + return;> +> + p += snprintf(info+p, max-p, "pos:\t%lli\n", (long long) file->f_pos);> + p += snprintf(info+p, max-p, "flags:\t0%o\n", file->f_flags);
Actually, snprintf() is not the right function to use here.scnprintf(), perhaps?
Vegard
-- "The animistic metaphor of the bug that maliciously sneaked in whilethe programmer was not looking is intellectually dishonest as itdisguises that the error is the programmer's own creation." -- E. W. Dijkstra, EWD1036_______________________________________________Containers mailing listContainers@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx://lists.linux-foundation.org/mailman/listinfo/containers
