Eric W. Biederman wrote: > 6 months ago when I introduced net_alive I fixed the symptoms > but I failed to properly fix network namespace shutdown. > > I realized this when I received a bug report on Tuesday about a > failure in icmp_send caused by packets in the arp_gueue. > > It turns out that the net_alive check in netif_receive_skb > is completely unnecessary and just masked the real problem. > > If we remove all network devices from a network namespace before we > shutdown network subsystems and protocols then as designed we cannot > have packets in flight causing problems. > > It turns out that the root cause of these problems is that the icmp > code was calling register_pernet_device instead of > register_pernet_subsys and so it's cleanup was happening much too > early. > > The following patchset which should work against both 2.6.29-rcX > and net-next fixes the registration problems and removes the > unncessary net_alive check, making the code simpler and hopefully > more comprehensible. > Hi Dave, I don't see these patches in the net-2.6 tree. Shouldn't they be in net-2.6 too ? -- Daniel _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
