Quoting Serge E. Hallyn (serue@xxxxxxxxxx): > Quoting Sukadev Bhattiprolu (sukadev@xxxxxxxxxxxxxxxxxx): > > > > From: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx> > > Date: Tue, 27 Jan 2009 22:58:18 -0800 > > Subject: [v2][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts > > > > On remount, devpts fs only needs to parse the mount options. Users cannot > > directly create/dirty files in /dev/pts so the MS_RDONLY flag and > > shrinking the dcache does not really apply to devpts. > > > > So effectively on remount, devpts only parses the mount options and updates > > these options in its super block. As such, we could replace do_remount_sb() > > call with a direct parse_mount_options(). > > > > Doing so enables subsequent patches to avoid parsing the mount options twice > > and simplify the code. > > You've dropped the update_ptmx_mode() which you used to do > inside devpts_remount(). Is that also on purpose? Since it appears that mknod_ptmx() will be called anyway and will do the same thing, > > Signed-off-by: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx> Acked-by: Serge Hallyn <serue@xxxxxxxxxx> _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
