Re: [PATCH 1/1] c/r: define s390-specific checkpoint-restart code (v3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



SH> +static void cr_save_cpu_regs(struct cr_hdr_cpu *hh, struct task_struct *t)
SH> +{

<snip>

SH> +	/* per_info */
SH> +	memcpy(&hh->per_control_regs, &thread->per_info.control_regs.words,
SH> +		3 * sizeof(unsigned long));
SH> +	hh->em_instr = 0;
SH> +	if (thread->per_info.single_step)
SH> +		hh->em_instr |= 1;
SH> +	if (thread->per_info.instruction_fetch)
SH> +		hh->em_instr |= 2;

I think that defining these constants (3, 1, and 2) would help me
understand what's being done here.  You use them again in
cr_read_cpu(), which also makes it worthwhile I think.

-- 
Dan Smith
IBM Linux Technology Center
email: danms@xxxxxxxxxx

_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers

[Index of Archives]     [Cgroups]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux