On Wed, Jan 28, 2009 at 10:30:01PM -0800, Sukadev Bhattiprolu wrote: > > From: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx> > Date: Wed, 28 Jan 2009 17:11:13 -0800 > Subject: [RFC][PATCH] simple_set_mnt() should return void > > simple_set_mnt() is defined to return int but always returns 0. > Callers assume simple_set_mnt() never fails and don't properly > cleanup if it were to _ever_ fail. For instance, get_sb_single() > and get_sb_nodev() should: > > up_write(sb->s_unmount); > deactivate_super(sb); > > if simple_set_mnt() fails. > > Since simple_set_mnt() never fails, would be cleaner if it did > not return anything. Makes sense to me. Feel free to resend once you did an allmodconfig or similar build. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
