On Thu, 2008-12-04 at 09:41 +0100, Ingo Molnar wrote:
> * Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> >
> > On Wed, 3 Dec 2008, Andrew Morton wrote:
> >
> > > On Wed, 03 Dec 2008 15:36:57 -0500
> > > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > >
> > > > +static struct seq_operations ftrace_graph_seq_ops = {
> > > > + .start = g_start,
> > > > + .next = g_next,
> > > > + .stop = g_stop,
> > > > + .show = g_show,
> > > > +};
> > >
> > > This could be static I think.
> >
> > s/static/const/
> >
> > Damn damn damn damn!!!! I said to myself, I need to add const there and
> > still forgot :-(
>
> No need to get stressed up about such details - we need checkpatch help
> for this.
I guess it would be too much for checkpatch, but I think sparse can do
it, it just means steve has to install sparse and actually run the
thing ;-)
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
