On Mon, 1 Dec 2008 09:51:35 +0530 Nikanth Karthikesan <knikanth@xxxxxxx> wrote: > Ok. Then should we remove the unused code which simply checks for thread group > leader but does nothing? > > Thanks > Nikanth > Hmm, it seem that code is obsolete. thanks. Balbir, how do you think ? Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> Anyway we have to visit here, again. > Remove the unused test for thread group leader in mem_cgroup_move_task. > > Signed-off-by: Nikanth Karthikesan <knikanth@xxxxxxx> > > --- > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 866dcc7..8e9287d 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1151,14 +1151,6 @@ static void mem_cgroup_move_task(struct cgroup_subsys > *ss, > mem = mem_cgroup_from_cont(cont); > old_mem = mem_cgroup_from_cont(old_cont); > > - /* > - * Only thread group leaders are allowed to migrate, the mm_struct is > - * in effect owned by the leader > - */ > - if (!thread_group_leader(p)) > - goto out; > - > -out: > mmput(mm); > } > > > _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
