On Wed, 26 Nov 2008 00:16:26 -0500 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> From: Steven Rostedt <rostedt@xxxxxxxxxxx>
>
> Impact: enhancement to function graph tracer
>
> Export the trace_find_cmdline so the function graph tracer can
> use it to print the comms of the threads.
>
> -static char *trace_find_cmdline(int pid)
> +char *trace_find_cmdline(int pid)
>
> ...
>
> static int verif_pid(struct trace_seq *s, pid_t pid)
> {
> + char *comm;
> +
> if (last_pid != -1 && last_pid == pid)
> return 1;
>
> last_pid = pid;
> - return trace_seq_printf(s, "\n------------8<---------- thread %d"
> + comm = trace_find_cmdline(pid);
> +
> + return trace_seq_printf(s, "\n------------8<---------- thread %s-%d"
> " ------------8<----------\n\n",
> - pid);
> + comm, pid);
> }
This code gets its int's and pid_t's all mixed up. It's a bit cosmetic, but
nice to get it right for readability's sake.
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
