Paul Menage wrote: > On Fri, Nov 21, 2008 at 11:05 AM, Paul Menage <menage@xxxxxxxxxx> wrote: >> Wouldn't this be fixed by your patch that adds an rcu_read_lock() to >> task_subsys_state() ? >> > > Sorry, your other patch actually adds the rcu_read_lock() to > task_cgroup(). But adding an rcu_read_lock() to task_subsys_state() > would also help here. Adding an rcu_read_lock() to task_subsys_state() also help here. But task_subsys_state() is used in fast path. If we add an implicit rcu_read_lock() in task_subsys_state(), we still need rcu_read_lock()/task_lock() for using it, so it's redundant rcu_read_lock(), and slower the fast path a little. Lai. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
