On Thu, 06 Nov 2008 02:38:49 -0800
ebiederm@xxxxxxxxxxxx (Eric W. Biederman) wrote:
>
> In the last refactoring of shrink_submounts a variable was
> not completely renamed. So finish the renaming of mnt to m
> now.
>
> Without this if you attempt to mount an nfs mount that has
> both automatic nfs sub mounts on it, and has normal mounts
> on it. The unmount will succeed when it should not.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
> ---
> fs/namespace.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index cce4670..65b3dc8 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -1815,8 +1815,8 @@ static void shrink_submounts(struct vfsmount *mnt, struct list_head *umounts)
> while (!list_empty(&graveyard)) {
> m = list_first_entry(&graveyard, struct vfsmount,
> mnt_expire);
> - touch_mnt_namespace(mnt->mnt_ns);
> - umount_tree(mnt, 1, umounts);
> + touch_mnt_namespace(m->mnt_ns);
> + umount_tree(m, 1, umounts);
> }
> }
> }
OK, so that's a for-2.6.28 bugfix, yes?
The other six patches will fall under Alexey's procfs tree.
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
