Paul Menage wrote: > On Thu, Jul 10, 2008 at 2:14 AM, Nadia Derbey <Nadia.Derbey@xxxxxxxx> wrote: > >>But I think that both ways of doing are not exactly the same in case of >>failure: >>open + dup2 will close newfd if it is already busy. >>while >>next-syscall_data + open will fail if the target fd is already busy. And >>that's the functionality we need during restart, isn't it? > > > No, I don't think so. The cryo restart code should be aware of exactly > which fds it has open and which it needs to open, and can shuffle them > around as necessary via dup2() to get them into the right places. > Yes sure, that's exactly what it does. what I just wanted to say here is that the concept of opening + dup2'ing is not exactly the same as the open_with_id concept. But I agree with you: a restart code knows exactly what it does and can safely play with the open and dup syscalls. Regards, Nadia _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers