On Thu, 2008-06-19 at 18:54 -0700, sukadev@xxxxxxxxxx wrote: > Matt Helsley [matthltc@xxxxxxxxxx] wrote: <snip> > | if (pipefds[0] != restarted_read_fd) { > | dup2(pipefds[1], restarted_write_fd); > | close(pipefds[1]); > | } > > Shouldn't the last if be > > if (pipefds[1] != restarted_wrte_fd) ? > > (otherwise it would break if pipefds[0] = 11 and pipefds[1] = 200) Argh, copy-paste error. You are correct. > I came up with something similar, but with an extra close(). And > in my code, I had restarted_* names referring to pipefds[] making > it a bit confusing initially. > > How about using actual_fds[] (instead of pipefds) and expected_fds[] > instead of (restart_*) ? I like actual_fds[] instead of pipefds[] but still prefer the restart_* names over expected_fds[]. Cheers, -Matt _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers