Dave Hansen wrote: > On Tue, 2008-06-10 at 01:33 +0200, Andrea Righi wrote: >> + cgroup_unlock(); >> + >> + count = sprintf(page, "CommitLimit: %8lu kB\n" >> + "Committed_AS: %8lu kB\n", >> + K(allowed), K(committed)); >> + ret = simple_read_from_buffer(userbuf, nbytes, ppos, page, count); >> +out: >> + free_page((unsigned long)page); >> + return ret; >> +} > > I know you're trying to make this look like meminfo, but it does butcher > the sysfs rules a bit. How about breaking it out into a couple of > files? > > -- Dave Sounds reasonable. Anyway, I think this patchset should be simply dropped in favor of the Balbir's memrlimit controller, as reported by Kamezawa. The memrlimit controller permits to implement the overcommit policies in userspace directly setting the cgroup VM limits (well.. I've not read the memrlimit source yet, but from the documentation it seems so). -Andrea _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
