Andrew wrote:
> As Matt observed, this is just a poorly-named variable.
How about the following code for cgroup_file_write():
char buf[64]; /* avoid kmalloc() in small cases */
char *p; /* buf[] or kmalloc'd buffer */
...
if (nbytes < sizeof(buf)) {
p = buf;
} else {
p = kmalloc(nbytes + 1, GFP_KERNEL);
if (p == NULL)
return -ENOMEM;
}
Possible advantages of above code:
* Uses short names for local variables of limited scope.
* Doesn't set p until needed, so as:
1) to highlight the symmetry of its setting, to either buf[]
(small cases) or to a kmalloc'd buffer (large cases), and
2) to avoid implying that p needs to be set in the intervening
"..." code above.
* Comments variable declarations.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.940.382.4214
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
