On Tue, May 13, 2008 at 1:11 PM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, 12 May 2008 23:37:13 -0700
> menage@xxxxxxxxxx wrote:
>
> > @@ -1412,14 +1355,18 @@ static struct cftype files[] = {
> > {
> > .name = "cpus",
> > .read = cpuset_common_file_read,
> > - .write = cpuset_common_file_write,
> > + .write_string = update_cpumask,
> > + .max_write_len = (100U + 6 * NR_CPUS),
>
> hm, magic handwavy surely-enough-for-anyone constants.
This is just a movement of the check previously in cpuset_common_file_write():
/* Crude upper limit on largest legitimate cpulist user might write. */
if (nbytes > 100U + 6 * max(NR_CPUS, MAX_NUMNODES))
return -E2BIG;
I'll add more comments. But I think it's a reasonable limit - assuming
that you wastefully enumerate each cpu individually, separated by
commas, 6 * NR_CPUS is enough for 100K CPUs.
Paul
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
