On Feb 17, 2008 9:49 PM, Li Zefan <lizf@xxxxxxxxxxxxxx> wrote: > opts.release_agent is not kfree()ed in all necessary places. > > Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx> Acked-by: Paul Menage <menage@xxxxxxxxxx> Good catch, although hopefully something that would be extremely rare in practice. Thanks, Paul > --- > kernel/cgroup.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index 0c35022..aa76bbd 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -961,8 +961,11 @@ static int cgroup_get_sb(struct file_system_type *fs_type, > } > > root = kzalloc(sizeof(*root), GFP_KERNEL); > - if (!root) > + if (!root) { > + if (opts.release_agent) > + kfree(opts.release_agent); > return -ENOMEM; > + } > > init_cgroup_root(root); > root->subsys_bits = opts.subsys_bits; > -- > 1.5.4.rc3 > > _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers