Denis V. Lunev wrote: > On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote: >> Denis V. Lunev wrote: >>> Default ARP parameters should be findable regardless of the context. >>> Required to make inetdev_event working. >>> >>> Signed-off-by: Denis V. Lunev <den@xxxxxxxxxx> >>> --- >>> net/core/neighbour.c | 4 +--- >>> 1 files changed, 1 insertions(+), 3 deletions(-) >>> >>> diff --git a/net/core/neighbour.c b/net/core/neighbour.c >>> index c895ad4..45ed620 100644 >>> --- a/net/core/neighbour.c >>> +++ b/net/core/neighbour.c >>> @@ -1275,9 +1275,7 @@ static inline struct neigh_parms *lookup_neigh_params(struct neigh_table *tbl, >>> struct neigh_parms *p; >>> >>> for (p = &tbl->parms; p; p = p->next) { >>> - if (p->net != net) >>> - continue; >>> - if ((p->dev && p->dev->ifindex == ifindex) || >>> + if ((p->dev && p->dev->ifindex == ifindex && p->net == net) || >>> (!p->dev && !ifindex)) >>> return p; >>> } >> If the values are: >> p->dev == NULL >> ifindex == 0 >> p->net != net >> >> The parms should not be taken into account and the looping must >> continue. But with this modification it is not the case, if we specify >> parms ifindex == 0, the first parms with the dev field set to NULL will >> be taken belonging or not to the right net. > > They should be taken. In the other case inetdev_event will fail for sure > in the middle. You could check. > > These are ARP defaults and I do not see a problem for now to get them. Because there is a parms default per namespace. So several instances of them per nd table. That was the initial approach with Eric's patchset. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers