YAMAMOTO Takashi wrote: >> Li Zefan wrote: >>> No need for VM_BUG_ON(pc), since 'pc' is the list entry. This should >>> be VM_BUG_ON(page). >>> >>> Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx> >>> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> >> pc is of type page_cgroup and we use list_for_each_entry_safe_reverse. Not sure >> why we can't bug on pc. > > pc is dereferenced before this VM_BUG_ON. > > YAMAMOTO Takashi > OK, so the VM_BUG_ON needs to move to an earlier location. Agreed. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers