On Tue, 12 Feb 2008 16:15:00 +0100 Nadia Derbey <Nadia.Derbey@xxxxxxxx> wrote: > Andrew Morton wrote: > > On Tue, 12 Feb 2008 10:32:31 +0100 Nadia Derbey <Nadia.Derbey@xxxxxxxx> wrote: > > > > > >>it builds fine, modulo some changes in ipv4 and ipv6 (see attached patch > >>- didn't find it in the hot fixes). > > > > > > OK, thanks for checking. Did you confirm that we don't have unneeded code > > in vmlinux when CONFIG_PROCFS=n? I guess before-and-after comparison of > > the size(1) output would tell us. > > > > Those networking build problems appear to have already been fixed. > > > > In future, please quote the compiler error output in the changelog when > > sending build fixes or warning fixes, thanks. > > > > > > > > BEFORE: > > lkernel@akt$ size vmlinux > text data bss dec hex filename > 4318525 454484 462848 5235857 4fe491 vmlinux > > > AFTER: > > lkernel@akt$ size vmlinux > text data bss dec hex filename > 4323161 454484 462848 5240493 4ff6ad vmlinux > > which makes it +4636 = +0.11% > > I've got the details for */built-in.o if needed. > That seems to be a lot of increase. Are you sure you had CONFIG_PROCFS=n in both cases? If so, the patch must have added a lot of code which will never be executed? _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers