KAMEZAWA Hiroyuki wrote: > This check is not necessary now. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > > > Index: linux-2.6.24-rc3-mm2/mm/memcontrol.c > =================================================================== > --- linux-2.6.24-rc3-mm2.orig/mm/memcontrol.c > +++ linux-2.6.24-rc3-mm2/mm/memcontrol.c > @@ -860,9 +860,7 @@ retry: > /* Avoid race with charge */ > atomic_set(&pc->ref_cnt, 0); > if (clear_page_cgroup(page, pc) == pc) { > - int active; > css_put(&mem->css); > - active = pc->flags & PAGE_CGROUP_FLAG_ACTIVE; Good Catch, __mem_cgroup_remove_list() takes care of this. > res_counter_uncharge(&mem->res, PAGE_SIZE); > __mem_cgroup_remove_list(pc); > kfree(pc); > Acked-by: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers