[snip] >> + &namespaces, path, table); > > Hey Eric, > > the patches look nice. Agree ;) > The hand-forcing of the passed-in net_ns into a copy of current->nsproxy > does make it seem like nsproxy may not be the best choice of what to > pass in. Doesn't only net_sysctl_root->lookup() look at the argument? > > But I assume you don't want to be more general than sending in a > nsproxy so as to dissuade abuse of this interface for needlessly complex > sysctl interfaces? > > (Well I expect that'll become clear once the the patches using this > come out.) > > Are you planning to use this infrastructure for the uts and ipc > sysctls as well? I have sent some patches concerning uts and ipc already. I'd appreciate any feedback on it :) > thanks, > -serge Thanks, Pavel _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers