Daniel Lezcano <dlezcano@xxxxxxxxxx> writes: > Eric W. Biederman wrote: >> Now that multiple loopback devices are becoming possible it makes >> the code a little cleaner and more maintainable to test if a deivice >> is th a loopback device by testing dev->flags & IFF_LOOPBACK instead >> of dev == loopback_dev. >> >> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> > > > Urs Thuermann posted the patch: > > [PATCH 5/7] CAN: Add virtual CAN netdevice driver > > This network driver set its flag to IFF_LOOPBACK for testing. > Is it possible this can be a collision with your patch ? I have brought it up on that thread. As best as I tell the CAN usage of IFF_LOOPBACK will be a problem even without my patch. Assuming something other then the CAN layer will see the CAN devices. The CAN documentations IFF_LOOPBACK should be set on all CAN devices. It seems that the people who want high performance predictable CAN don't want this and the people who want something they can trace easily want this. It sounds to me like CAN routers don't exist. Anyway hopefully that usage can be resolved as that code is reviewed, and made ready to merge. Eric _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
